Code Review Print

  • devopsinfrastructure, devops, security, troubleshooting, guide, howto, solution, zillionkinghost
  • 0

Checking each other's work.

WHY REVIEW

Catching problems before they reach production Spreading knowledge of the system Maintaining consistency

WHAT TO LOOK FOR

Correctness Security faults Edge cases and failure paths Clarity Anything surprising

WHAT NOT TO SPEND TIME ON

Formatting, which a tool should handle.

WHAT MAKES REVIEW WORK

Small changes Clear descriptions Prompt responses

WHY SMALL CHANGES

A large change receives a cursory review.

WHAT TO DO AS A REVIEWER

Ask questions rather than issuing instructions Distinguish must-change from preference Approve when it is good enough, not perfect

WHAT TO DO AS AN AUTHOR

Explain why, not only what Respond to every comment Do not take it personally

WHAT TO AUTOMATE BEFORE REVIEW

Formatting Static analysis Tests

WHY

So review addresses what only a person can judge.

WHAT TO ESTABLISH

Who reviews, and how quickly.


Was this answer helpful?
Back

Are you happy with your experience? Leave us a review on Trustpilot.


Trustpilot